Skip to content

Conversation

biboudis
Copy link
Contributor

@biboudis biboudis commented Feb 27, 2019

  • Add blogpost (main item for review)
  • Add a CHANGELOG.md
  • Rename Eq to Eql a the typeclass derivation to resemble to the new one scala.Eql

@biboudis biboudis added stat:wip itype:meta Issues about process/similar labels Feb 27, 2019
@biboudis biboudis self-assigned this Feb 27, 2019
@biboudis biboudis requested a review from odersky February 27, 2019 17:33
@smarter smarter force-pushed the add-blogpost branch 2 times, most recently from 0660551 to e2f6a86 Compare February 27, 2019 18:33
@biboudis
Copy link
Contributor Author

biboudis commented Feb 28, 2019

The dotty-example-project for mill is blocked (scala/scala3-example-project#26), should I remove the relevant section? Opinions?

@smarter
Copy link
Member

smarter commented Feb 28, 2019

The dotty-example-project for mill is blocked (scala/scala3-example-project#26), should I remove the relevant section? Opinions?

Yes, I probably won't have time to fix mill in the near future.

@biboudis
Copy link
Contributor Author

biboudis commented Mar 1, 2019

Thank you all, I'll merge on Monday in case we receive more comments. Then the word is "out" 🎉

smarter
smarter previously requested changes Mar 1, 2019
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!

@biboudis biboudis force-pushed the add-blogpost branch 2 times, most recently from ef1fde5 to 6b691a2 Compare March 5, 2019 10:21
@biboudis
Copy link
Contributor Author

biboudis commented Mar 5, 2019

Thank you all for the comments! 🙏

@biboudis biboudis merged commit 0558618 into scala:master Mar 5, 2019
@biboudis biboudis deleted the add-blogpost branch March 5, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
itype:meta Issues about process/similar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants